Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add KeycloakAdmin.get_idp() #478

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: add KeycloakAdmin.get_idp() #478

merged 1 commit into from
Nov 13, 2023

Conversation

derlin
Copy link
Contributor

@derlin derlin commented Aug 18, 2023

Add the missing get_idp(alias) method. Note that the failing tests are the one from master (related to auth), the idp ones finish with success.

@derlin
Copy link
Contributor Author

derlin commented Aug 29, 2023

@ryshoooo, @marcospereirampj any thoughts?

ryshoooo
ryshoooo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @derlin!

Very useful endpoint, I usually just went through the list given by get_idps, so this is a great improvement :)

@ryshoooo ryshoooo merged commit 6899022 into marcospereirampj:master Nov 13, 2023
NoDataIsAvailable pushed a commit to NoDataIsAvailable/python-keycloak-extended that referenced this pull request Jan 8, 2024
@derlin
feat: add KeycloakAdmin.get_idp() (marcospereirampj#478)
e272547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryshoooo ryshoooo ryshoooo approved these changes

@marcospereirampj marcospereirampj Awaiting requested review from marcospereirampj marcospereirampj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derlin @ryshoooo